Skip to content

Conversation

momvart
Copy link
Contributor

@momvart momvart commented May 20, 2024

@rustbot
Copy link
Collaborator

rustbot commented May 20, 2024

r? @celinval

rustbot has assigned @celinval.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 20, 2024
@rustbot
Copy link
Collaborator

rustbot commented May 20, 2024

This PR changes Stable MIR

cc @oli-obk, @celinval, @ouz-a

@celinval
Copy link
Contributor

Looks good to me. What do you think about adding a conversion from IntrinsicDef to FnDef?

@momvart
Copy link
Contributor Author

momvart commented May 23, 2024

What do you think about adding a conversion from IntrinsicDef to FnDef?

Makes sense and I added it. I initially defined IntrinsicDef as a wrapper around FnDef but it didn't structurally match well with Instance.

@celinval
Copy link
Contributor

Awesome! I noticed from your test that we need to update the Instance::has_body(), and I created rust-lang/project-stable-mir#79 to track that fix. But that's completely orthogonal to this change. So let's go ahead and merge it. Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 23, 2024

📌 Commit 6743fc7 has been approved by celinval

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2024
Rollup of 7 pull requests

Successful merges:

 - rust-lang#122382 (Detect unused structs which implement private traits)
 - rust-lang#124389 (Add a warning to proc_macro::Delimiter::None that rustc currently does not respect it.)
 - rust-lang#125224 (Migrate `run-make/issue-53964` to `rmake`)
 - rust-lang#125227 (Migrate `run-make/issue-30063` to `rmake`)
 - rust-lang#125336 (Add dedicated definition for intrinsics)
 - rust-lang#125401 (Migrate `run-make/rustdoc-scrape-examples-macros` to `rmake.rs`)
 - rust-lang#125454 (Improve the doc of query associated_item)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c700590 into rust-lang:master May 23, 2024
@rustbot rustbot added this to the 1.80.0 milestone May 23, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2024
Rollup merge of rust-lang#125336 - momvart:smir-77-intrinsic, r=celinval

Add dedicated definition for intrinsics

Closes rust-lang/project-stable-mir#77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an API to check if a function is intrinsic
4 participants